Fix hassio warnings and false True (positive) for DisableLinkage feature #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1 Detected blocking call to load_default_certs Signed-off-by: Jan Dušek <[email protected]>
Unify the way it is done elsewhere to prevent excesive false positive retun of True when DisableLinkage is actually available and returns error from camera. After thsi fix, it is queried twice and then the integration knows it is unavailable. Signed-off-by: Jan Dušek <[email protected]>
|
Thank you! |
|
For retest, I replaced my local modified code with latest release and is is OK in logs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hassio warning about blocking SSL setup
Detected blocking call to load_default_certsandsetup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is doneAlso fixed approach how to detect if DisableLinkage feature is present which return false True (positive) even when the feature is not present in the camera and direct cgi-bin call return 400 error.